discuit icon indicating copy to clipboard operation
discuit copied to clipboard

[Suggestion] Sort by all

Open Kaamkiya opened this issue 1 year ago • 3 comments

The current sort options don't include all, which is odd because it's built in already.

For example, https://discuit.net/?sort=all shows the most popular posts of all time, and https://discuit.net/?sort=year shows this year only.

I'd like to make a PR for this.

EDIT: Looking closer, there is already a line of code for this, but it's hidden. Why is that?

Kaamkiya avatar Sep 24 '24 21:09 Kaamkiya

EDIT: Looking closer, there is already a line of code for this, but it's hidden. Why is that?

Because on the desktop view it makes the feed-sort-bar too long causing it to overflow, I removed the All option as a quick fix. At the time, that was totally fine, since Discuit was under a year old.

image

I think it's time to redesign this UI component. Perhaps a drop-down would be a better choice.

previnder avatar Sep 25 '24 08:09 previnder

Ohhh, that makes sense. A dropdown would be good.

Kaamkiya avatar Sep 25 '24 11:09 Kaamkiya

I'll start development on this.

Kaamkiya avatar Sep 28 '24 18:09 Kaamkiya

Hey @Kaamkiya, I had to complete this as part of the feed compact mode add. Hope you don't mind.

previnder avatar Oct 12 '24 20:10 previnder

That's alright. Thanks for implementing it :)

Kaamkiya avatar Oct 17 '24 20:10 Kaamkiya