prometheus_exporter icon indicating copy to clipboard operation
prometheus_exporter copied to clipboard

Published 20 hours ago • verified publisher icon discourse

fix: custom_labels on SidekiqStatsCollector and SidekiqProcessCollector

Open mbarany opened this issue 2 months ago • 5 comments

Fixes https://github.com/discourse/prometheus_exporter/issues/196

mbarany avatar Sep 12 '25 02:09 mbarany

@SamSaffron this is ready for review. thanks

mbarany avatar Sep 17 '25 21:09 mbarany

I am a bit confused, when did the shape of the data change to include the "process" key? will this break old installs?

also tests appear to be failing

SamSaffron avatar Sep 17 '25 23:09 SamSaffron

I fixed the tests.

In collect we will now pass the entire hash to @sidekiq_metrics which includes the custom_labels. I think this does not change the shape and is backwards compatible. Let me know if you prefer a different approach.

mbarany avatar Sep 19 '25 04:09 mbarany

bump ^ @SamSaffron

mbarany avatar Sep 26 '25 14:09 mbarany

bump again ^ @SamSaffron

mbarany avatar Nov 20 '25 17:11 mbarany