add "opus/silk/arm/NSQ_neon.c" to the "target_arch==\"arm64\"" condit…

Open deepso7 opened this issue 1 year ago • 5 comments

## Description

Fixes dyld: missing symbol called on macOS and apple silicon as reported in #165

Dec 03 '24 10:12 deepso7

@vladfrangu Can this get reviewed and merged?

Feb 10 '25 23:02 krische

Is this needed? I've been able to use it on macos M1 without this 👀

Feb 11 '25 00:02 vladfrangu

Is this needed? I've been able to use it on macos M1 without this 👀

Interesting, I'm targeting linux/arm64/v8 container platform in my GitHub build and it's failing to compile opus inside it for I believe the error this PR fixes. I'll have to try and isolate it further to reproduce.

Feb 11 '25 00:02 krische

If you can get us a repro dockerfile or such that'd be lovely too! Including the JS code to test locally 🙏

Feb 11 '25 00:02 vladfrangu

Howdy everybody. I was about to make a pull request of my own to get this issue fixed. I'm using an M4 and I continue to also have error.

May 05 '25 15:05 Scronkfink

Any chance we can get a release published with this merged change?

Jul 09 '25 00:07 krische