guide icon indicating copy to clipboard operation
guide copied to clipboard

Modifying example to search command subfolders

Open JonathanRJoyner opened this issue 1 year ago • 5 comments

This portion of the guide is confusing because it does not work with a previous section title "Command Categories" which has the user move commands in to subcommand folders.

The changes I've made allow for the full commands folder to be searched for a matching command. This will work no matter the path to the file inside the command folder.

JonathanRJoyner avatar Jul 13 '23 02:07 JonathanRJoyner

This would require users to download the glob package using npm. As this is not stated on the page, I would recommend adding a part for installing the package.

GodderE2D avatar Jul 20 '23 09:07 GodderE2D

Good point. Added a line about installing glob.

JonathanRJoyner avatar Aug 20 '23 16:08 JonathanRJoyner

Wait, you're making this change to reflect the command categories page, right? So why should we use a different approach than that page? I'd say either use fs here, or also make the categories page use glob.

GodderE2D avatar Aug 20 '23 17:08 GodderE2D

I don't think changes like these are needed especially when the new guide is in the works.

sdanialraza avatar Aug 20 '23 17:08 sdanialraza

This portion of the guide is confusing because it does not work with a previous section title "Command Categories" which has the user move commands in to subcommand folders.

Just pointing out that this issue is resolved.

Jiralite avatar Dec 29 '23 18:12 Jiralite