guide icon indicating copy to clipboard operation
guide copied to clipboard

feat(slashcommands): add JSON objects along with builders

Open megatank58 opened this issue 2 years ago • 2 comments

Please describe the changes this PR makes and why it should be merged:

#1122 Adding JSON objects as an alternative option to builders will allow advanced developers to ~~copy paste~~ understand code quickly and something that is more native to them.

One question is whether the builders page should also have the JSON objects for direct comparison with builders or should they not have them as the page is specifically made for builders?

megatank58 avatar Jun 06 '22 07:06 megatank58

I also disagree with having this in the first place, we don't need a raw json example for everything, that'd be ass to maintain and just unneeded stuff cluttering the guide imo. What I would rather do is recommend builders and link to the api docs and perhaps mention discord-api-types for typescript users. In the case of the "advanced users", that should be enough for them.

BenjammingKirby avatar Jun 06 '22 07:06 BenjammingKirby

Switched to enums

megatank58 avatar Jun 14 '22 08:06 megatank58

This will need to be revisited after the semantic and structural rewrite that's currently in progress

almostSouji avatar Oct 17 '22 10:10 almostSouji

It's probably better to remake this pr entirely (or rethink the idea as a whole) as the codebase has changed a lot.

megatank58 avatar Jan 27 '23 04:01 megatank58