discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

source code should be included with packages on npm

Open DetachHead opened this issue 1 year ago • 2 comments

Which package is this bug report for?

discord.js

Issue description

from #9481:

Selected builders cuz it's the one I noticed the issue in but it applies to all TS packages. Basically the .js.map files are being sent to npm, which then breaks error stacks for people with source map support enabled since you can't Ctrl + click the file paths as they lead to the .ts files which are not in your directory.

re-raising because the original issue suggested removing the source maps instead of including the source code. see my comment https://github.com/discordjs/discord.js/issues/9481#issuecomment-1593148514:

the source maps should stay in the npm package, but the source code should be included too. that way, ctrl+click would work and show the source code instead of the compiled js

Code sample

No response

Versions

discord.js 14.11.0

Issue priority

Low (slightly annoying)

Which partials do you have configured?

Not applicable

Which gateway intents are you subscribing to?

Not applicable

I have tested this issue on a development release

No response

DetachHead avatar Jul 10 '23 09:07 DetachHead

As stated here, this is not happening.

didinele avatar Jul 10 '23 13:07 didinele

Never mind actually, I miss read.

didinele avatar Jul 10 '23 13:07 didinele