discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

perf: linear speed position getters

Open jaw0r3k opened this issue 2 years ago • 2 comments
trafficstars

Please describe the changes this PR makes and why it should be merged: Backports:

  • https://github.com/discordjs/discord.js/pull/9497

The other pr isnt backported as current performance is 59 ms per 100_000 iterations Where kyra's is 132 ms

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

jaw0r3k avatar May 06 '23 19:05 jaw0r3k

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 11:16am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 11:16am

vercel[bot] avatar May 06 '23 19:05 vercel[bot]

Upstream PR landed with different checks.

kyranet avatar Jul 09 '23 21:07 kyranet

Please resolve conflicts.

Jiralite avatar Jul 19 '23 05:07 Jiralite

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 93
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-git-fork-jaw0r3k-v13-linear-speed-p-f6889b-discordjs.vercel.app/

github-actions[bot] avatar Aug 25 '23 11:08 github-actions[bot]