discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

fix(BitField): use only enum names in iterating

Open jaw0r3k opened this issue 1 year ago • 4 comments

Please describe the changes this PR makes and why it should be merged: Resolves: #9350 The change may seem weird, but its working. As enums are reverse mapped, getting keys will not only give names but values The shown exception was permissions, but its just an object

Status and versioning classification:

  • Typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

jaw0r3k avatar Apr 09 '23 15:04 jaw0r3k

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 5:27pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 5:27pm

vercel[bot] avatar Apr 09 '23 15:04 vercel[bot]

@jaw0r3k is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 09 '23 15:04 vercel[bot]

It looks like this needs backporting, would you mind doing it?

Jiralite avatar Apr 13 '23 16:04 Jiralite

It looks like this needs backporting, would you mind doing it?

Sure <3

jaw0r3k avatar Apr 13 '23 16:04 jaw0r3k

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 98
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-git-fork-jaw0r3k-patch-4-discordjs.vercel.app/

github-actions[bot] avatar Apr 28 '23 17:04 github-actions[bot]