discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

feat: super reactions

Open jaw0r3k opened this issue 1 year ago • 4 comments

Please describe the changes this PR makes and why it should be merged:

  • https://github.com/discord/discord-api-docs/pull/6056
  • https://github.com/discord/discord-api-docs/pull/6375

Status and versioning classification:

  • Code changes have been tested against the Discord API
  • I know how to update typings and have done so
  • This PR changes the library's interface (methods or parameters added)

jaw0r3k avatar Apr 07 '23 11:04 jaw0r3k

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 8:08pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 8:08pm

vercel[bot] avatar Apr 07 '23 11:04 vercel[bot]

@jaw0r3k is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 07 '23 11:04 vercel[bot]

Removed the following:

  • https://github.com/discord/discord-api-docs/pull/6375
  • https://github.com/discord/discord-api-docs/pull/6377
  • https://github.com/discordjs/discord-api-types/pull/744

They can be done separately when ready.

Jiralite avatar Feb 21 '24 08:02 Jiralite

Looks like to properly implement this, we need to https://github.com/discord/discord-api-docs/pull/6375 so we can discern the kind of reaction we receive from the gateway to manually update the counts:

https://github.com/discordjs/discord.js/blob/c89c343b0a6f74fc760ae6a2dab42cc07fef6b39/packages/discord.js/src/client/actions/MessageReactionAdd.js#L35-L41

https://github.com/discordjs/discord.js/blob/c89c343b0a6f74fc760ae6a2dab42cc07fef6b39/packages/discord.js/src/structures/MessageReaction.js#L124-L139

Jiralite avatar Feb 21 '24 10:02 Jiralite