discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

feat: Voice Channel Send Effects

Open Jiralite opened this issue 1 year ago • 7 comments

Please describe the changes this PR makes and why it should be merged:

  • https://github.com/discord/discord-api-docs/pull/6025
  • https://github.com/discordjs/discord-api-types/pull/739

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Jiralite avatar Mar 28 '23 09:03 Jiralite

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 1:46am
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 1:46am

vercel[bot] avatar Mar 28 '23 09:03 vercel[bot]

@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 28 '23 09:03 vercel[bot]

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-git-fork-jiralite-feat-voice-effects-discordjs.vercel.app/

github-actions[bot] avatar Mar 28 '23 09:03 github-actions[bot]

may you add channel getter?

jaw0r3k avatar Mar 28 '23 10:03 jaw0r3k

also shouldn't it be an action, which handlers just handle like every other event?

jaw0r3k avatar Mar 28 '23 20:03 jaw0r3k

may you add channel getter?

This seems to already be done.

Jiralite avatar Apr 02 '23 08:04 Jiralite

also shouldn't it be an action, which handlers just handle like every other event?

https://github.com/discordjs/discord.js/blob/b27c1d0819ce408899fd0ced404c0a3dd6b19be9/packages/discord.js/src/client/actions/Action.js#L5-L15

My take on this is until there are any REST events that affect this event or we need to manually call this code, there is no need to add it. It is a very simple structure: receive a WebSocket event then emit it. Also, not every event has an action. So no, it shouldn't be an action.

Jiralite avatar Apr 02 '23 08:04 Jiralite