discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

refactor: remove zlib-sync

Open didinele opened this issue 1 year ago • 5 comments

Please describe the changes this PR makes and why it should be merged: draft because vlad wants us to keep zlib-sync & the new pure-native node:zlib impl together for a few dev releases

Status and versioning classification:

didinele avatar Mar 26 '23 12:03 didinele

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 26, 2023 at 0:19AM (UTC)

vercel[bot] avatar Mar 26 '23 12:03 vercel[bot]

@didinele is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 26 '23 12:03 vercel[bot]

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 71
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-guide-git-fork-didinele-refactor-na-c3e2f9-discordjs.vercel.app/

github-actions[bot] avatar Mar 26 '23 12:03 github-actions[bot]

Codecov Report

Merging #9279 (37e7135) into main (ba93bc8) will decrease coverage by 0.02%. The diff coverage is 31.03%.

@@            Coverage Diff             @@
##             main    #9279      +/-   ##
==========================================
- Coverage   83.54%   83.53%   -0.02%     
==========================================
  Files         100      100              
  Lines        9574     9578       +4     
  Branches     1103     1103              
==========================================
+ Hits         7999     8001       +2     
- Misses       1535     1537       +2     
  Partials       40       40              
Flag Coverage Δ
ws 57.60% <31.03%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/ws/src/ws/WebSocketShard.ts 21.14% <9.09%> (-0.61%) :arrow_down:
packages/ws/src/utils/constants.ts 86.30% <100.00%> (+0.19%) :arrow_up:
packages/ws/src/ws/WebSocketManager.ts 96.27% <100.00%> (+0.07%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Mar 26 '23 12:03 codecov[bot]

Just a small followup to this issue: I created a PR for zlib-sync that addresses it not compiling on NodeJS 21 https://github.com/abalabahaha/zlib-sync/pull/11

JMTK avatar Oct 24 '23 17:10 JMTK

closing in favor of a new PR since this has the branch on my fork and it's just a whole mess to work with.

didinele avatar May 03 '24 13:05 didinele