discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

feat(Widget): support fetching widget image

Open dager-mohamed opened this issue 2 years ago • 11 comments

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

dager-mohamed avatar Sep 03 '22 20:09 dager-mohamed

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 10, 2022 at 6:30PM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Oct 10, 2022 at 6:30PM (UTC)

vercel[bot] avatar Sep 03 '22 20:09 vercel[bot]

Are you still maintaining this @dager-mohamed? Seems like there are merge conflicts and unresolved conversations

almeidx avatar Oct 09 '22 23:10 almeidx

Are you still maintaining this @dager-mohamed? Seems like there are merge conflicts and unresolved conversations

idk why there are merge conflicts, but there are no resolved conversations

dager-mohamed avatar Oct 10 '22 05:10 dager-mohamed

GuildWidgetStyle needs to be added to the APITypes file

almeidx avatar Oct 10 '22 08:10 almeidx

@dager-mohamed is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 10 '22 13:10 vercel[bot]

GuildWidgetStyle needs to be added to the APITypes file

all things are done

dager-mohamed avatar Oct 10 '22 13:10 dager-mohamed

now done

dager-mohamed avatar Oct 10 '22 18:10 dager-mohamed

There are still conversations that are marked as resolved but are not resolved.

done

dager-mohamed avatar Oct 10 '22 18:10 dager-mohamed

No, not done. Re-review the conversations.

Jiralite avatar Oct 10 '22 18:10 Jiralite

No, not done. Re-review the conversations.

bro where?

dager-mohamed avatar Oct 10 '22 18:10 dager-mohamed

https://github.com/discordjs/discord.js/pull/8589/files#r991311523

You were told it is not a great description (which it is not). You resolved it without making any changes, leaving it to be still a lacklustre description.

https://github.com/discordjs/discord.js/pull/8589/files#r991539399

This ideally shouldn't have a default. I don't see a reason why discord.js should default it.

https://github.com/discordjs/discord.js/pull/8589/files#r962216556

You've been told this one hasn't been resolved multiple times, despite marking it as resolved. No changes have been made here.

Jiralite avatar Oct 10 '22 18:10 Jiralite

Superseded by #9782.

Jiralite avatar Aug 18 '23 15:08 Jiralite