discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

Published 20 hours ago • verified publisher icon discordjs

feat(NewsChannel)!: return created webhook id

Open Syjalo opened this issue 2 years ago • 2 comments

Please describe the changes this PR makes and why it should be merged: This PR changes the return type of NewsChannel#addFollower() method to the created webhook id.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

Syjalo avatar Aug 28 '22 16:08 Syjalo

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Aug 28, 2022 at 4:26PM (UTC)

vercel[bot] avatar Aug 28 '22 16:08 vercel[bot]

I agree with this change. Sadly, this is currently breaking.

What we can do in a non-breaking way is add this method to the GuildChannelManager as it doesn't exist (for some reason). That would not be breaking and the return type can be a Snowflake. In the breaking change, we would internally call the GuildChannelManager.

Jiralite avatar Aug 28 '22 16:08 Jiralite