discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

fix: remove `ActionRow.from()`

Open Syjalo opened this issue 2 years ago • 6 comments

Please describe the changes this PR makes and why it should be merged: This PR removes ActionRow.from() since it contains incorrect docs, has no types and shouldn't be in a component.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

Syjalo avatar Aug 16 '22 15:08 Syjalo

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Aug 16, 2022 at 3:43PM (UTC)

vercel[bot] avatar Aug 16 '22 15:08 vercel[bot]

Doesn't this go against the RFC?

EDIT: Misread, thought this was about builders

vladfrangu avatar Aug 16 '22 15:08 vladfrangu

Codecov Report

Merging #8502 (29d0616) into main (acdafe6) will increase coverage by 26.74%. The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #8502       +/-   ##
===========================================
+ Coverage   59.54%   86.29%   +26.74%     
===========================================
  Files          12       87       +75     
  Lines        1466     8362     +6896     
  Branches       87     1105     +1018     
===========================================
+ Hits          873     7216     +6343     
- Misses        592     1103      +511     
- Partials        1       43       +42     
Flag Coverage Δ
builders 100.00% <ø> (?)
collection 100.00% <ø> (?)
proxy 73.28% <ø> (?)
rest 92.53% <ø> (?)
utilities 100.00% <ø> (?)
voice 64.08% <ø> (?)
ws 59.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/voice/src/joinVoiceChannel.ts 100.00% <0.00%> (ø)
packages/voice/src/audio/TransformerGraph.ts 74.60% <0.00%> (ø)
packages/builders/src/components/Component.ts 100.00% <0.00%> (ø)
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)
...ashCommands/mixins/ApplicationCommandOptionBase.ts 100.00% <0.00%> (ø)
packages/voice/src/receive/SSRCMap.ts 86.20% <0.00%> (ø)
.../src/interactions/slashCommands/options/boolean.ts 100.00% <0.00%> (ø)
packages/rest/src/lib/REST.ts 98.86% <0.00%> (ø)
...ixins/ApplicationCommandOptionChannelTypesMixin.ts 100.00% <0.00%> (ø)
packages/builders/src/interactions/modals/Modal.ts 100.00% <0.00%> (ø)
... and 65 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 16 '22 15:08 codecov[bot]

Can you make a pull request to emit a deprecation warning to use the ActionRowBuilder's static method?

Jiralite avatar Aug 16 '22 18:08 Jiralite

I just checked the src/structures/ActionRow.js and it does emit a deprecation warning.

CitTheDev avatar Oct 10 '22 02:10 CitTheDev

That would be because of #8504. The communication wasn't good here, but thank you for pointing it out.

Jiralite avatar Oct 10 '22 14:10 Jiralite