discord.js
discord.js copied to clipboard
feat(Emoji): create `getURL()` function to get more extension of emoji
Please describe the changes this PR makes and why it should be merged:
discordjs support only .gif
and .png
for emoji extension, so I created the getURL(ext)
function to make the user get any extension of emoji he wants.
Status and versioning classification:
Please move lines that apply to you out of the comment:
- Code changes have been tested against the Discord API, or there are no code changes
- I know how to update typings and have done so, or typings don't need updating
- This PR changes the library's interface (methods or parameters added)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
Name | Status | Preview | Updated |
---|---|---|---|
discord-js | ⬜️ Ignored (Inspect) | Aug 15, 2022 at 3:25PM (UTC) |
I agree with thehackerboi that .url should be a getter So making function like getUrl would be better
I agree with thehackerboi that .url should be a getter So making a function like getUrl would be better
so I have an idea and I don't know if this idea is like you said or not,
I can create getUrl(URL)
as you said function inside the class to check the URL of the emoji and then return the extension,
and I will use the getUrl()
function inside url()
and it will be getter that you mean?
I hope that you mean.
Nah i just mean getURL(ext) which will return a url and leave url as getter ( like everywhere else )
ahaa ok i understand now, i will do it
now i added the getUrl(ext)
function and url
is a getter now.
note: the rest.cdn is automatically throw the error at all
Codecov Report
Merging #8493 (d0aaca6) into main (cb85686) will decrease coverage by
13.45%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## main #8493 +/- ##
============================================
- Coverage 100.00% 86.54% -13.46%
============================================
Files 2 87 +85
Lines 843 9250 +8407
Branches 159 1854 +1695
============================================
+ Hits 843 8005 +7162
- Misses 0 1189 +1189
- Partials 0 56 +56
Flag | Coverage Δ | |
---|---|---|
builders | 100.00% <ø> (?) |
|
collection | 100.00% <ø> (ø) |
|
proxy | 83.45% <ø> (?) |
|
rest | 94.90% <ø> (?) |
|
utilities | 100.00% <ø> (ø) |
|
voice | 64.29% <50.00%> (?) |
|
ws | 63.60% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
packages/voice/src/audio/AudioPlayerError.ts | 0.00% <0.00%> (ø) |
|
packages/voice/src/audio/AudioResource.ts | 95.60% <ø> (ø) |
|
packages/voice/src/joinVoiceChannel.ts | 100.00% <ø> (ø) |
|
packages/voice/src/networking/Networking.ts | 3.42% <ø> (ø) |
|
packages/voice/src/VoiceConnection.ts | 81.14% <100.00%> (ø) |
|
packages/actions/src/formatTag/formatTag.ts | 100.00% <0.00%> (ø) |
|
packages/voice/src/receive/SSRCMap.ts | 86.66% <0.00%> (ø) |
|
...src/interactions/contextMenuCommands/Assertions.ts | 100.00% <0.00%> (ø) |
|
packages/voice/src/receive/SpeakingMap.ts | 100.00% <0.00%> (ø) |
|
... and 81 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Superseded by #9788.