discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

Published 20 hours ago • verified publisher icon discordjs

feat: split `CommandInteractionOptionResolver`

Open Syjalo opened this issue 2 years ago • 3 comments

Please describe the changes this PR makes and why it should be merged: This PR splits CommandInteractionOptionResolver to make methods visible in the docs only what are available in the context.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Syjalo avatar Aug 05 '22 11:08 Syjalo

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 5:51PM (UTC)

vercel[bot] avatar Aug 05 '22 11:08 vercel[bot]

I don't see how this split is correct?

Why are the methods for subcommands, subcommand groups and the primitive types (string, number, integer, boolean) removed from the AutocompleteInteractionOptionResolver? They should all still work, as the value doesn't require any resolved structures.

I thought the issue was only that Discord doesn't send resolved data for Users/GuildMembers, Roles and Channels in AutocompleteInteraction.

Also this is 100% breaking. You changed the interface.

monbrey avatar Aug 07 '22 12:08 monbrey

Sweden

Rebazkoye avatar Aug 10 '22 10:08 Rebazkoye