discord.js icon indicating copy to clipboard operation
discord.js copied to clipboard

feat: add support for guild forums

Open suneettipirneni opened this issue 3 years ago • 9 comments
trafficstars

Please describe the changes this PR makes and why it should be merged:

Note This PR is blocked by the rest of the documentation by published upstream

WIP/Draft based on known documentation of guild forum threads:

  • https://github.com/discord/discord-api-docs/pull/4761
  • https://github.com/discord/discord-api-docs/pull/5007
  • https://github.com/discord/discord-api-docs/pull/4850
  • https://github.com/discord/discord-api-docs/pull/5206

Status and versioning classification: Please move lines that apply to you out of the comment:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

suneettipirneni avatar Apr 13 '22 04:04 suneettipirneni

From looking at the implementation in Discord, I had the feeling forum threads would act differently from text channel threads because of things like the reactions and the OP tag, are you sure this isn't the case?

That isn't in the docs:

WIP/Draft based on known documentation of guild forum threads:

suneettipirneni avatar Apr 13 '22 14:04 suneettipirneni

Well you didn't add the channel flags

ImRodry avatar Apr 13 '22 14:04 ImRodry

Well you didn't add the channel flags

It's still a draft PR

suneettipirneni avatar Apr 13 '22 14:04 suneettipirneni

This needs a rebase

vladfrangu avatar May 19 '22 14:05 vladfrangu

@suneettipirneni When can you get this PR done?

BenPatersonxx avatar Jun 05 '22 09:06 BenPatersonxx

Can we see some work in here or remove it from the v14 milestone?

GravIos3 avatar Jun 18 '22 19:06 GravIos3

  • discord/discord-api-docs#5206

almeidx avatar Jul 19 '22 17:07 almeidx

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 17, 2022 at 11:45PM (UTC)

vercel[bot] avatar Jul 20 '22 16:07 vercel[bot]

This neeeds a rebase~

vladfrangu avatar Aug 07 '22 11:08 vladfrangu

Would love to implement this for the Railway.app server. Just got access to forums and we have a few automations that'll break when switching from thread only channels.

Thanks for the swell work y'all!

JakeCooper avatar Aug 12 '22 07:08 JakeCooper

Heya, what work is remaining on this PR? Would love to assist if possible.

webrender avatar Aug 19 '22 16:08 webrender

Codecov Report

Merging #7791 (45bd884) into main (669c3cd) will decrease coverage by 13.49%. The diff coverage is n/a.

@@             Coverage Diff              @@
##              main    #7791       +/-   ##
============================================
- Coverage   100.00%   86.50%   -13.50%     
============================================
  Files           39       87       +48     
  Lines         3087     8672     +5585     
  Branches       410     1110      +700     
============================================
+ Hits          3087     7502     +4415     
- Misses           0     1128     +1128     
- Partials         0       42       +42     
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (?)
proxy 74.10% <ø> (?)
rest 91.99% <ø> (?)
utilities 100.00% <ø> (?)
voice 63.86% <ø> (?)
ws 60.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/ws/src/strategies/sharding/worker.ts 0.00% <0.00%> (ø)
packages/ws/src/ws/WebSocketManager.ts 95.69% <0.00%> (ø)
packages/rest/src/lib/errors/RateLimitError.ts 100.00% <0.00%> (ø)
packages/voice/src/receive/SpeakingMap.ts 100.00% <0.00%> (ø)
packages/voice/src/receive/VoiceReceiver.ts 90.56% <0.00%> (ø)
packages/voice/src/networking/VoiceWebSocket.ts 0.00% <0.00%> (ø)
packages/collection/src/collection.ts 100.00% <0.00%> (ø)
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)
.../src/strategies/sharding/WorkerShardingStrategy.ts 95.87% <0.00%> (ø)
...trategies/context/SimpleContextFetchingStrategy.ts 71.42% <0.00%> (ø)
... and 38 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 30 '22 14:08 codecov[bot]

This pull request is missing the changes to the createChannel function in util/Channels.js.

dynamicbark avatar Aug 30 '22 19:08 dynamicbark

This pull request requires https://github.com/discord/discord-api-docs/pull/5453 to merge, right?

Jiralite avatar Sep 13 '22 16:09 Jiralite

Forums are now publically available to all servers.

cobaltt7 avatar Sep 14 '22 16:09 cobaltt7

Also is it correct that bots can't create tags? The client is using POST /channels/:id/tags, which is not documented (as far as I saw)

Just looked through the pull requests in the original message here and could not find the documentation for it (as well as just looking at the current documentation now). Also, I've noticed that there is no documentation to create a forum channel with forum-specific payloads - only editing a channel has that documentation. Strange.

Jiralite avatar Sep 17 '22 14:09 Jiralite

any news?

guinhx avatar Mar 29 '23 01:03 guinhx

That's vague. If you have a query, you can ask on the Discord server or create a new discussion.

Jiralite avatar Mar 29 '23 02:03 Jiralite