builders icon indicating copy to clipboard operation
builders copied to clipboard

Validation errors

Open KokoNeotSide opened this issue 3 years ago • 3 comments

Feature

Please revert back the validation errors. This new "Zod" thing is terrible. I've been searching for 2h where the issue is because it doesn't tell you where the error is.

Ideal solution or implementation

Revert back to the previous validator (ow) which said what exact fields and commands are causing issues

Alternative solutions or implementations

No response

Other context

image image

the first image, I'm missing description for one command, there is no way for me to read that from the error. the second image, I accidentally made one command name first letter capital. All I know that my regex is invalid somewhere in 50 commands. This is terrible

KokoNeotSide avatar Jan 01 '22 08:01 KokoNeotSide

That's not happening, ow switched to ESM-only and has caused many issues in the past due to it.

We'll most likely switch to ShapeShift, which Sapphire devs have been building to improve the experience and performance of the validation process.

kyranet avatar Jan 01 '22 10:01 kyranet

@kyranet Are there any benchmarks for shapeshift compared to zod or other validation libs?

KhafraDev avatar Jan 01 '22 16:01 KhafraDev

Yes, @vladfrangu has them.

kyranet avatar Jan 01 '22 16:01 kyranet