CEV-Eris icon indicating copy to clipboard operation
CEV-Eris copied to clipboard

Purge

Open vode-code opened this issue 2 years ago • 9 comments

About The Pull Request

This PR removes the old Syndicate Mobs, the Blob Event, the Shock Pack and Electric Chair, and a variety of unused code.

Why It's Good For The Game

the less old code there is, the less tech debt there is.

Testing

launched properly, joined game, saw no abnormalities, walked around, saw no abnormalities

Changelog

:cl: del: Removed Blob Event del: Removed Electropack del: Removed Manhack Grenades and Viscerators code: removed a variety of unused files /:cl:

vode-code avatar Jul 11 '23 01:07 vode-code

I love removing code and then refusing to add any other features to fill in the feature void ,especially when said features are not extremly prone to bugs and have proven to work fine.

MLGTASTICa avatar Jul 11 '23 01:07 MLGTASTICa

Dont remove the blob. shock pack and electric chair aren't even used but why remove blob?

ValoTheValo avatar Jul 11 '23 01:07 ValoTheValo

No, compiled successfully isn't proper testing.

Firefox13 avatar Jul 11 '23 06:07 Firefox13

No, compiled successfully isn't proper testing.

joining a server without a ckey is completely disabled by #8096 due to bad index ckey runtime.

vode-code avatar Jul 11 '23 06:07 vode-code

Join while logged in then.

Iglpigl avatar Jul 11 '23 06:07 Iglpigl

People use manhacks and vivisectors what the hell are you on about

assortedbeads avatar Jul 11 '23 08:07 assortedbeads

No, compiled successfully isn't proper testing.

joining a server without a ckey is completely disabled by #8096 due to bad index ckey runtime.

its not due to a runtime its litteraly a server config change by default to not allow guest keys. Just change the config.

MLGTASTICa avatar Jul 11 '23 13:07 MLGTASTICa

Cam also be changed live in server tab

Firefox13 avatar Jul 11 '23 13:07 Firefox13

joining a server without a ckey is completely disabled by #8096 due to bad index ckey runtime.

its not due to a runtime its litteraly a server config change by default to not allow guest keys. Just change the config.

while guest keys may not runtime, lacking any key at all does runtime, and can be done by running the game server without running a BYOND client.

vode-code avatar Jul 12 '23 02:07 vode-code