CEV-Eris
CEV-Eris copied to clipboard
discordia-space
Remove COCO_FOOD from morale bar
About The Pull Request
Removed tag COCO_FOOD from the ration morale bar since it contains no cocoa. Makes it similar to Shokolad bar in effect of fulfilling COCOA desires (it doesn't). Changed Shokolad description to better identify that it is NOT FUCKING CHOCOLATE TASTING DESPITE THE NAME.
Why It's Good For The Game
Brings the morale bar in line with other foods that are not produced by cooking
Changelog
:cl: tweak: Changed Shokolad description to try and identify that it is not valid for Chocolate desires balance: Removed COCO_FOOD taste tag from the ration Morale bar since it does not have cocoa in the preloaded reagents /:cl:
It appears that you've mixed /obj/item/reagent_containers/food/snacks/shokoloud and /obj/item/reagent_containers/food/snacks/candy/mre together by accident when making the description.
Fair. But consider, what if chocolate bars actually fulfilled desire for chocolate? Yes, those are pretty fake, but those come to mind, not some bay leftover hidden in the depths of food recipe wiki page. So average player finds or buys a chocolate bar aaaand it doesn't work for them. Would they understand why? Maybe, but most likely they'll count that as a bug.
Fair. But consider, what if chocolate bars actually fulfilled desire for chocolate? Yes, those are pretty fake, but those come to mind, not some bay leftover hidden in the depths of food recipe wiki page. So average player finds or buys a chocolate bar aaaand it doesn't work for them. Would they understand why? Maybe, but most likely they'll count that as a bug.
Wait, does junk_food = TRUE prevent a food from completing a desire?
It appears that you've mixed
/obj/item/reagent_containers/food/snacks/shokoloudand/obj/item/reagent_containers/food/snacks/candy/mretogether by accident when making the description.
Mea culpa, but I thought the two should be linked - if not I can remake the PR. Not a super high priority fix either so it can wait for a more well-done (ha!) version if needed.
Fair. But consider, what if chocolate bars actually fulfilled desire for chocolate? Yes, those are pretty fake, but those come to mind, not some bay leftover hidden in the depths of food recipe wiki page. So average player finds or buys a chocolate bar aaaand it doesn't work for them. Would they understand why? Maybe, but most likely they'll count that as a bug.
The problem is that shokolad is junk food which can't fulfill desires and IIRC all junk food is blocked from fulfilling desires. I could remove it from spawns but at that point we might want to just replace all cases of shokolad with chocolate bars or vice versa. Since it appears I won't be allowed to do that, I've opted to just change the description to try and tell people "hey this shit is shit and doesn't fulfill desires for insights, even if it has cocoa powder in it."
Wait, does
junk_food = TRUEprevent a food from completing a desire?
It wouldn't restore sanity.
The problem is that shokolad is junk food which can't fulfill desires and IIRC all junk food is blocked from fulfilling desires.
Is it really? I can't see anything in the code that would prevent it from doing so, please point out exact lines.
I could remove it from spawns but at that point we might want to just replace all cases of shokolad with chocolate bars or vice versa. Since it appears I won't be allowed to do that, I've opted to just change the description to try and tell people "hey this shit is shit and doesn't fulfill desires for insights, even if it has cocoa powder in it."
Why? Shokolad looks good and in Eris style, unlike godawful ancient bay chocolate. If anything, it should replace old chocolate, not the other way around.
if(junk_food || !cooked) message += " However, only healthy food will help you grow." return list(sanity_gain_pb, SPAN_NOTICE(message))
Doesn't this line block it?
if(junk_food || !cooked) message += " However, only healthy food will help you grow." return list(sanity_gain_pb, SPAN_NOTICE(message))Doesn't this line block it?
It tells you that junk food isn't good for you. That's it, it just prints a message.
The problem is that shokolad is junk food which can't fulfill desires and IIRC all junk food is blocked from fulfilling desires.
Is it really? I can't see anything in the code that would prevent it from doing so, please point out exact lines.
I could remove it from spawns but at that point we might want to just replace all cases of shokolad with chocolate bars or vice versa. Since it appears I won't be allowed to do that, I've opted to just change the description to try and tell people "hey this shit is shit and doesn't fulfill desires for insights, even if it has cocoa powder in it."
Why? Shokolad looks good and in Eris style, unlike godawful ancient bay chocolate. If anything, it should replace old chocolate, not the other way around.
I agree, Shokolad is much more the Eris style, but I'd want support from at least some of the other developers to merge the two - as it is Shokolad seems to be a useful junk spawn to provide cocoa powder if you can't get it any other way.
@hyperioo please DO NOT MERGE this yet - it might warrant greater rework on Shokolad and Chocolate bars and taste.
@hyperioo please DO NOT MERGE this yet - it might warrant greater rework on Shokolad and Chocolate bars and taste.
Then just convert it to draft.
Wait, does junk_food = TRUE prevent a food from completing a desire?
Yes. All maintenance junk food, not just shokolad bars, fail to fulfill desires. This has confused people before. I'm not sure why chocolate bars are being singled out.
Wait, does junk_food = TRUE prevent a food from completing a desire?
Yes. All maintenance junk food, not just shokolad bars, fail to fulfill desires. This has confused people before. I'm not sure why chocolate bars are being singled out.
because chocolate is really hard desire to fulfill normally and people keep thinking shokolad works for whatever reason. None of the other junk foods have the same hard-to-fulfill niche
just make shokolad give you chocolate desire. chocolate bars should probably count as chocolate yknow. without having to code dive for some ancient bay rescipie
Going to close and redo this as adding COCO flavor to shokolad. Thank you all for your input.