CEV-Eris icon indicating copy to clipboard operation
CEV-Eris copied to clipboard

Fixes the ammo pouch being able to hold drum mags

Open GrayRachnid opened this issue 2 years ago • 7 comments

About The Pull Request

Title image

Why It's Good For The Game

Normal sized items should not fit in a pouch.

Changelog

:cl: balance: Ammo pouches can no longer hold ammo boxes and drum magazines. /:cl:

GrayRachnid avatar Aug 12 '22 15:08 GrayRachnid

don't merge my last pr after requesting changes while i'm asleep

GrayRachnid avatar Aug 12 '22 15:08 GrayRachnid

RIP LMG ammo pouch 2018-2022

ValoTheValo avatar Aug 12 '22 16:08 ValoTheValo

I disagree for one reason: drums should take 2 slots, and LMG boxes should take 3. this way you get 6 normal (180 round), 3 drum (135 rounds) or 2 lmg (160 rounds) not sure how it woul work in code. bigger items remove 1/2 slots?

maikilangiolo avatar Aug 12 '22 16:08 maikilangiolo

why i disagree: you would kill magazine storage a bit too hard, we can nerf it properly without such an extreme change

maikilangiolo avatar Aug 12 '22 16:08 maikilangiolo

I disagree for one reason: drums should take 2 slots, and LMG boxes should take 3. this way you get 6 normal (180 round), 3 drum (135 rounds) or 2 lmg (160 rounds) not sure how it woul work in code. bigger items remove 1/2 slots?

yeah this is fair

ValoTheValo avatar Aug 12 '22 16:08 ValoTheValo

I disagree for one reason: drums should take 2 slots, and LMG boxes should take 3. this way you get 6 normal (180 round), 3 drum (135 rounds) or 2 lmg (160 rounds) not sure how it woul work in code. bigger items remove 1/2 slots?

yeah this is fair

There is no code to support this and coding a system just for ammo pouches and satisfying you is too much work and out of scope of this PR. If you want to carry normal sized mags, use a bigger storage.

GrayRachnid avatar Aug 12 '22 16:08 GrayRachnid

I think you could do that by switching to continuous storage instead of slot storage, like in #7369

But the thing is meant to store magazines, the description is litteraly "Can hold ammo magazines and bullets, not the boxes though." and the sprite is clearly a mag pouch.

image

So it does not make a lot of sense to fit a whole ammo box or LMG chonky mag.

Of course, from a gameplay perspective, it could be changed.

hyperioo avatar Aug 12 '22 17:08 hyperioo

But the thing is meant to store magazines, the description is litteraly "Can hold ammo magazines and bullets, not the boxes though."

Said "boxes" are the loose bullet boxes which hold 240 rounds, used to refill mags. The mag pouch can hold the smaller ammo packets, but not the ammo boxes.

maikilangiolo avatar Aug 18 '22 14:08 maikilangiolo