lilliput icon indicating copy to clipboard operation
lilliput copied to clipboard

No Windows support

Open samsamm777 opened this issue 6 years ago • 3 comments

Could someone kindly outline the challenges with supporting windows? Whether it works on windows, but unsupported, or doesnt work and for what reasons? This would be a great help in assessing whether we can use this.

samsamm777 avatar Apr 05 '18 13:04 samsamm777

I don't really have a suitable machine to build on. If you want to try running deps/build_deps_linux.sh on Windows and massaging it until it works, that would probably be the way to go. You'll either need to find a way to build all the deps using something that isn't Make, or use mingw to get all the posixy bits building. But if you do the latter, it won't be compatible with msvc.

brian-armstrong-discord avatar Apr 09 '18 23:04 brian-armstrong-discord

Thanks Brian, this is promising. We'll take a look at getting a windows script going and see how it fairs. If we get something going, ill PR it back for you guys to share.

samsamm777 avatar Apr 10 '18 10:04 samsamm777

I made it compile on Windows, not sure if everything works yet.

Though CMAKE is giving me huge headaches because it keeps postfixing the libraries with "320", the version number of the used OpenCV and there doesn't seem to be a way to disable that without mangling with CMAKE itself. None of the involved CMakelists.txt files have any hint on it, either.

Also Intels "ippicv" cant be used unless one would somehow manage to make it all compile using MSVC AND have Go be into it.

Check the fork here: https://github.com/sinni800/lilliput

also lilliput-dep-source has another file called have_boolean_windows.patch

--- grfmt_jpeg.cpp	2019-03-10 16:37:19.276282300 +0100
+++ grfmt_jpeg.1.cpp	2019-03-10 16:37:20.876564300 +0100
@@ -68,6 +68,7 @@
 
 #if defined WIN32 && defined __GNUC__
 typedef unsigned char boolean;
+#define HAVE_BOOLEAN
 #endif
 
 #undef FALSE

It's needed for building, but not for just using the thing.

Also after building, the files in deps\windows\x64\mingw\staticlib will have to have the "320" suffix removed, I couldn't figure out how ot make cmake do it without that suffix.

sinni800 avatar Mar 10 '19 17:03 sinni800