lilliput icon indicating copy to clipboard operation
lilliput copied to clipboard
verified publisher icon discord

Add support for macOS on Apple Silicon

Open acj opened this issue 1 year ago • 4 comments

As discussed in #157, this PR contributes the following:

  1. Adds dependencies built for macOS on ARM / Apple Silicon
  2. Removes dependencies built for macOS on Intel x86_64
  3. Adds GitHub Actions CI workflows for building the dependencies and for building and testing Lilliput itself
  4. Fixes several issues that were breaking the build on macOS and Linux

I tried to break things up into small commits for easier review. The last ~5 commits are the key changes -- adding arm64 support, adding CI, and rebuilding the dependencies. The rest are fixes for the build.

If you'd like me to make a separate PR for the CI stuff, I'm happy to do that. There's a test run of the main CI workflow here and one for the dependency workflow here.

Happy to talk through any questions or concerns. Thanks!

Resolves #157. Resolves #138. Resolves #139.

acj avatar May 23 '24 22:05 acj

@skidder :wave: A gentle ping. If I can do anything to make this easier to review and incorporate, let me know.

acj avatar Jul 19 '24 16:07 acj

hi, any updates on this PR?

aslamhadi avatar Sep 11 '24 10:09 aslamhadi

@skidder Thanks for landing #192. 👍 Are you interested in the CI workflow from this PR? If so, I can rebase and remove the changes that are already in master.

acj avatar Oct 11 '24 14:10 acj

@skidder Thanks for landing #192. 👍 Are you interested in the CI workflow from this PR? If so, I can rebase and remove the changes that are already in master.

@acj That would be amazing, yes, please!

skidder avatar Oct 11 '24 16:10 skidder

I opened #196 for the CI workflows.

acj avatar Oct 31 '24 20:10 acj