fix up uri encoding tests

Open brian-armstrong-discord opened this issue 8 years ago • 3 comments

i noticed these were broken when i attempted to run tests. we should make sure that nothing in these changes looks too troublesome

Jun 21 '17 22:06 brian-armstrong-discord

so it's probably still spooky that I dropped this code.. we should really fix it instead.. I think the idea is to normalize the user input.. requests does this successfully at https://github.com/requests/requests/blob/132040cc0378a787916474c33a7c9f693806a92f/requests/utils.py#L524

Jun 21 '17 23:06 night

k, then i'll just leave the pr open for now while we decide the right way to fix it

Jun 21 '17 23:06 brian-armstrong-discord

i looked at the source, i think it's because fasthttp was unencoding all.. when it should have been leaving them put.. it should only unencode

"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz" + "0123456789-._~"

i think just matching the logic of the requests util would probably fix our issue

Jun 21 '17 23:06 night