embedded-app-sdk icon indicating copy to clipboard operation
embedded-app-sdk copied to clipboard

[Problem] Install instructions react-colyseus example incomplete

Open Miniontoby opened this issue 1 year ago • 0 comments

Hi,

At the react-colyseus example the instructions are incomplete for installing

The current command shown is pnpm install: https://github.com/discord/embedded-app-sdk/blob/5cc3da806a8bc35b3a3b3c289975c7f14e662591/examples/react-colyseus/README.md?plain=1#L47

This however shows this:

miniontoby:/opt/discordactivities/react-colyseus $ pnpm install
Already up to date
Done in 2.2s
miniontoby:/opt/discordactivities/react-colyseus $

As you can see, it didn't install anything. I then ran the dev command that was after the install step, and it didn't work, because it was missing node_modules folder.

Looking at the dev command, I can see that the command runs pnpm run --filter \"./packages/**\" --parallel dev

So I ran pnpm install --filter "./packages/**" and it installed the packages and after that the dev command also worked.

So either the package.json needs to be altered OR the instructions in the README need to be altered...

Miniontoby avatar Mar 19 '24 15:03 Miniontoby