discord-open-source icon indicating copy to clipboard operation
discord-open-source copied to clipboard

Add SvelteJS

Open kevmodrome opened this issue 4 years ago • 9 comments

kevmodrome avatar Feb 08 '21 19:02 kevmodrome

STOP IT OF I HACK!

Op ma 8 feb. 2021 20:49 schreef Kevin Åberg Kultalahti < [email protected]>:


You can view, comment on, or merge this pull request online at:

https://github.com/discord/discord-open-source/pull/304 Commit Summary

  • Add Svelte
  • fix prettier autoformatting
  • fix formatting
  • fix svg

File Changes

Patch Links:

  • https://github.com/discord/discord-open-source/pull/304.patch
  • https://github.com/discord/discord-open-source/pull/304.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/discord/discord-open-source/pull/304, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQJMUDXBIPB7HXRSI375433S6A55LANCNFSM4XJTNIBQ .

Fatihbahadirvg avatar Feb 08 '21 19:02 Fatihbahadirvg

Turned on some features for you:

Do you want to update your invite code to something like discord.gg/<yourprojectname>?

jamiebuilds avatar Feb 09 '21 19:02 jamiebuilds

Hey Jamie,

https://discord.gg/svelte would be great.

Where will this appear? When we create invites in the server?

On Tue, 9 Feb 2021 at 19:41, Jamie Kyle [email protected] wrote:

Turned on some features for you:

Do you want to update your invite code to something like discord.gg/ ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/discord/discord-open-source/pull/304#issuecomment-776193084, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABVORJZAAB7CTSZ5NFBEETS6GFYDANCNFSM4XJTNIBQ .

--


ꜽ . antony jones . http://www.enzy.org

antony avatar Feb 09 '21 20:02 antony

You'll have to edit the invite code in your server, I cannot edit it for you. Docs here: https://support.discord.com/hc/en-us/articles/115001542132-Server-Vanity-URLs

jamiebuilds avatar Feb 09 '21 20:02 jamiebuilds

Would love to push forward on this. I've made a REPL with some logo choices that looks better with the filter. It's not part of https://github.com/sveltejs/branding though so we might need some acknowledgement from the Svelte team if it's fine.

image

bluwy avatar Jul 10 '21 16:07 bluwy

@vedam thoughts?

antony avatar Jul 10 '21 17:07 antony

Sorry, late to the party. I have a little problem to understand exactly what's needed and what this filter-thing is about. Are we talking of a discord-only solution? If I should choose from the 3 above I would say 1 and 2 are OK, but I would avoid 3, because the contrast of the outer-S is very low and the risk of getting optically mixed with the background is too high.

vedam avatar Jul 12 '21 06:07 vedam

@vedam The color changes are needed for this page, which uses a custom filter for the logos. I don't think it needs to be for discord-only, maybe it can be used for dark themes too

bluwy avatar Jul 12 '21 06:07 bluwy

Thx for the clarification. Version 1 from above will work best IMO.

vedam avatar Jul 12 '21 07:07 vedam