discord-api-docs icon indicating copy to clipboard operation
discord-api-docs copied to clipboard

Fix description for "username" in User resource

Open Xirado opened this issue 1 year ago • 3 comments

Usernames are unique across regular users.

Xirado avatar Aug 05 '24 14:08 Xirado

They aren't fully unique yet because bots still use discriminators. So the docs are currently still correct.

Lulalaby avatar Aug 05 '24 14:08 Lulalaby

Ahhh, totally forgot about Bots. yeah that makes sense. Maybe that should be included in the docs?

Xirado avatar Aug 05 '24 14:08 Xirado

I don't think this PR makes sense at the moment. Unless as a note with something like "Usernames are unique, except for bot users". But that sounds / feels unneeded at the moment imo.

Lulalaby avatar Aug 05 '24 14:08 Lulalaby

While I appreciate the sentiment, I think the way it's documented now is safer and more clear. If you need to account for bot users, which folks probably should .. they are not currently unique.

JustinBeckwith avatar Sep 05 '24 05:09 JustinBeckwith