discord-api-docs icon indicating copy to clipboard operation
discord-api-docs copied to clipboard

Published 20 hours ago • verified publisher icon discord

ETF Gateway leaking Guilds.Models.RecurrenceRule

Open Th3-M4jor opened this issue 8 months ago • 5 comments

Description

Similar to #4196 and #6320, another :__struct__ field is being leaked by the gateway, Guilds.Models.RecurrenceRule this time.

Steps to Reproduce

Currently unclear, I'm guessing this field is part of a GUILD_UPDATE event. It was reported for the Nostrum Library here.

Expected Behavior

No :__struct__ fields are sent as part of gateway events

Current Behavior

An event may include __struct__: Guilds.Models.RecurrenceRule in its body

Screenshots/Videos

No response

Client and System Information

Nostrum library on its latest commit.

Th3-M4jor avatar Dec 18 '23 02:12 Th3-M4jor

Ive recently been getting Guilds.Models.ScheduledEventException leaked.

Leastrio avatar Jan 24 '24 20:01 Leastrio

Heads up we still have Nostrum users receiving these structs.

It's not critical for us anymore since we added protections to remove struct keys received from upstream, but does remain a bug.

jb3 avatar May 07 '24 12:05 jb3

@jb3

Heads up we still have Nostrum users receiving these structs.

It's not critical for us anymore since we added protections to remove struct keys received from upstream, but does remain a bug.

Do you know which struct is being sent over the gateway? Is it still the Guilds.Models.ScheduledEventException or some other struct key?

ihumanable avatar May 07 '24 18:05 ihumanable

Do you know which struct is being sent over the gateway? Is it still the Guilds.Models.ScheduledEventException or some other struct key?

The one reported today is the ScheduledEventException, testing now it looks like recurrence rule seems to be okay (at least on scheduled event create, not sure where else that struct might be serialized over gateway).

jb3 avatar May 07 '24 19:05 jb3

Do you know which struct is being sent over the gateway? Is it still the Guilds.Models.ScheduledEventException or some other struct key?

The one reported today is the ScheduledEventException, testing now it looks like recurrence rule seems to be okay (at least on scheduled event create, not sure where else that struct might be serialized over gateway).

jb3 avatar May 07 '24 19:05 jb3

We have deployed a fix to prevent the __struct__ key from being leaked for Guilds.Models.ScheduledEventException.

Thanks so much for bringing this to our attention!

ollien avatar Jun 19 '24 00:06 ollien