Discord.Net icon indicating copy to clipboard operation
Discord.Net copied to clipboard

Inconsistent Design - Emote/GuildEmote Deletion & Modification

Open Still34 opened this issue 7 years ago • 2 comments

At the moment, we have 2 separate methods under IGuild called ModifyEmoteAsync and DeleteEmoteAsync, which doesn't seem to fit the modification/deletion verb design we have going on in the lib, namely ModifyAsync and DeleteAsync.

Shouldn't we make this Emote.ModifyAsync and Emote.DeleteAsync or under GuildEmote instead?

Still34 avatar Apr 19 '18 11:04 Still34

All of our Emote classes are in Core, since they're basically container types for data. Adding ModifyAsync/DeleteAsync would require a large breaking change to move them over into at least Rest

FiniteReality avatar May 17 '18 14:05 FiniteReality

Perhaps 3.0 then?

Still34 avatar May 21 '18 04:05 Still34