JDA icon indicating copy to clipboard operation
JDA copied to clipboard

Add newly_created field to ThreadChannel

Open Shea4 opened this issue 3 years ago • 2 comments

Pull Request Etiquette

Changes

  • [x] Internal code
  • [ ] Library interface (affecting end-user code)
  • [ ] Documentation
  • [ ] Other: _____

Closes Issue: N/A

Description

Adds a new method isNewlyCreated to ThreadChannel so you can differenciate when a ThreadChannel is created or if the self member joined the thread

Shea4 avatar Jun 05 '22 13:06 Shea4

Isn't this field only applicable to CHANNEL_CREATE events? I don't think it makes much sense to put that on the actual channel entity, when its primarily used to distinguish events.

MinnDevelopment avatar Jun 05 '22 14:06 MinnDevelopment

It is yes. Would a seperate event for THREAD_CREATE events be better or a method on the ChannelCreateEvent which throws if it's not for a thread, or any other suggestions you may have

Shea4 avatar Jun 05 '22 14:06 Shea4

I'm gonna need to read up more on how we'd use this, but this definitely should not be on the entity itself.

DV8FromTheWorld avatar Sep 12 '22 05:09 DV8FromTheWorld

Superseded by https://github.com/DV8FromTheWorld/JDA/pull/2254

DV8FromTheWorld avatar Sep 21 '22 01:09 DV8FromTheWorld