modern-indicators icon indicating copy to clipboard operation
modern-indicators copied to clipboard

Fix for Discord class changes

Open asportnoy opened this issue 3 years ago • 6 comments

Discord class changes broke the unread indicator.

asportnoy avatar Aug 20 '22 04:08 asportnoy

not too sure what this is fixing, theme works perfectly fine on both canary and stable builds. none of the classes were even rerolled for something to break. would appreciate some more elaboration 👍

LuckFire avatar Aug 20 '22 11:08 LuckFire

On channels where your notifications are set to only @mentions, Discord seems to have removed the .modeUnread-3Cxepe class. This is how it looks without the plugin: Screenshot on 2022-08-20 at 09 04 53 The unread-36eUEm class still exists for the dot before it, so I used that instead.

It's possible this is some A/B thing, as it seems like Discord might be trying to have people enable more notifications? I don't know.

asportnoy avatar Aug 20 '22 14:08 asportnoy

Just to make sure, it isn't some sort of plugin you have enabled is it?

LuckFire avatar Aug 20 '22 14:08 LuckFire

Yes, I can still reproduce with no plugins.

asportnoy avatar Aug 20 '22 14:08 asportnoy

Okay. I'll leave this opened for now since it's most likely an A/B thing. Discord also could have accidentally removed this class with it but I'm not too sure.

LuckFire avatar Aug 20 '22 14:08 LuckFire

FWIW, I don't think it's accidental. Discord added a banner to channels with notifications set to @mentions, telling people to set it to all messages. And the class is still there if it's set to all messages. This also fits with the various notification related changes Discord has been making, like redesigning the unread messages bubble: image

asportnoy avatar Aug 20 '22 14:08 asportnoy