Add support for line_item.key

Open stewartknapman opened this issue 9 years ago • 4 comments

TL;DR Actual awesome!

You'll probably see this later today, but Shopify have now released line_item.key. This adds a unique identifier to each line item, as apposed to line_item.id which didn't take into account line items with differing properties. https://help.shopify.com/themes/liquid/objects/line_item#line_item-key

This will probably also effect #92

Aug 24 '16 21:08 stewartknapman

👍

I am excited about this! I would say that the next version will drop support for modifying by index and make modifying by key the primary way to update existing items.

Re #92 - correct me if I'm wrong but there's still no way to update an existing item's properties, right?

Aug 25 '16 00:08 gavinballard

Ping @stewartknapman

Oct 09 '16 03:10 gavinballard

@gavinballard Was that ping regarding #92 ? I'm not sure I know what I was talking about.

Oct 09 '16 22:10 stewartknapman

@stewartknapman Yeah, it was. I'm not sure I know what I was talking about either :).

Oct 09 '16 23:10 gavinballard