extension
extension copied to clipboard
dis-moi
feat(profile): famous contributors
closes #998
@MaartenLMEM you can choose any famous contributors you want by editing famousContributors.json in the order you want Be careful to write the name of the contributor exactly as in the backoffice Could you also check the translation ?
The app configuration is done in env, we might want to change this but it should be discussed.
See similar feature for popular contributors (this isn't used but should be on install popin) and preselected contributors.
POPULAR_CONTRIBUTORS_IDS=[53, 54, 59, 46, 65]
PRESELECTED_CONTRIBUTORS_IDS=[16, 24, 25, 27, 29, 31, 42, 43, 44, 53, 54, 55, 59, 60, 65, 66, 67, 74]
The app configuration is done in
env, we might want to change this but it should be discussed.
The goal on this feature is to create something simple to manage for @MaartenLMEM . So using ids are to much complex for @MaartenLMEM beacause it need to go to backoffice and note ids for each contributors. Name is much simplier because it's dispalyed in front, just copy/past.
Env var is a good option, but we also would like something administrable from github
I tend to agree with @lutangar here, for the sake of consistency … @MaartenLMEM woud it be OK to store the list as an array of IDs that you would change here : https://github.com/dis-moi/extension/blob/master/.env.production ?
@lutangar actually, this could even be extracted from this physical file to hosted ENV, to enable deploy less editing …
@MaartenLMEM woud it be OK to store the list as an array of IDs that you would change here : https://github.com/dis-moi/extension/blob/master/.env.production ?
All right for me, need already discussed with Grégoire and Johan.
