extension icon indicating copy to clipboard operation
extension copied to clipboard

Feat/contribute design system

Open JalilArfaoui opened this issue 3 years ago • 10 comments

@newick I’ve rebased all ContributeSystem and chore/DesignSystemUpdate commits on master on this branch … please check everything is OK

JalilArfaoui avatar May 28 '21 18:05 JalilArfaoui

@JalilArfaoui can't run storybook in my local env. Well it runs but empty screen with no error in the console.

newick avatar Jun 02 '21 13:06 newick

I removed the whole project and cloned it again and it works… (cc @gregoirelacoste)

newick avatar Jun 02 '21 19:06 newick

Feedbacks after a look around

newick avatar Jun 02 '21 20:06 newick

@gregoirelacoste @JalilArfaoui @lutangar could you help me with the errors ⬆️ ?

newick avatar Jun 04 '21 08:06 newick

@gregoirelacoste @JalilArfaoui @lutangar you can review and merge it whenever you want.

newick avatar Jun 05 '21 08:06 newick

oh new bug! Links <a href=""> are broken

newick avatar Jun 05 '21 09:06 newick

@newick done for me could you check and merge if it's ok for you ?

gregoirelacoste avatar Jul 06 '21 13:07 gregoirelacoste

@gregoirelacoste it looks good to me. Are you ok to merge it?

newick avatar Jul 09 '21 09:07 newick

@gregoirelacoste it looks good to me. Are you ok to merge it?

Yes !

gregoirelacoste avatar Jul 09 '21 09:07 gregoirelacoste

@lutangar let's talk about it when you are around ;)

newick avatar Aug 19 '21 12:08 newick