uptime-kuma-helm icon indicating copy to clipboard operation
uptime-kuma-helm copied to clipboard

Published 20 hours ago • verified publisher icon dirsigler

Default strategy.type

Open dorkamotorka opened this issue 1 year ago • 1 comments

Any particular reason, why this is set to Recreate?

https://github.com/dirsigler/uptime-kuma-helm/blob/41f5e05f97a124db74d4d4e05a32337dcd102df8/charts/uptime-kuma/values.yaml#L146

In general, the default value should be RollingUpdate to conform with the Kubernetes default values or is there something I don't understand?

dorkamotorka avatar Oct 02 '23 09:10 dorkamotorka

The git blame says it was configured by me. That means it was probably the default value issued when creating a new Helm Chart. https://github.com/dirsigler/uptime-kuma-helm/blame/41f5e05f97a124db74d4d4e05a32337dcd102df8/charts/uptime-kuma/values.yaml#L146 But you are right that RollingUpdate is the default value set by Kubernetes itself.

If you want to configure anything else you can open a new PR with changes to set a custom value, else I can also add such change.

dirsigler avatar Oct 03 '23 16:10 dirsigler