dirs-rs icon indicating copy to clipboard operation
dirs-rs copied to clipboard
verified publisher icon dirs-dev

Question/Feature `Return error instead of compiler-error on non-supported platforms`

Open niklasad1 opened this issue 7 years ago • 1 comments

Hey,

What's your opinions on providing dummy implementation (returning None) for platforms that are not Windows, Linux or OSX?

If you are positive to this I have a branch ready to do that and can create a PR!

niklasad1 avatar Jul 18 '18 11:07 niklasad1

Hi @niklasad1, I don't have a fixed opinion on it, and would love to hear your position.

Which platforms do you have in mind? What would be the benefits? Wouldn't it be better to just fail compilation?

(Although I feel like with the deprecation of std::env::home_dir I'm now on the hook for supporting pretty much every operating system under the sun ...)

soc avatar Jul 23 '18 20:07 soc