demo example doesn't work and throws a error on browser console.

[rohitbishnoi]

[sudoanand]

Same issue, even on the example.html page provided with this package

[yringler]

Not compatible with videojs 7 Should be fixed by #33

[irieislaw4]

Same issue. Do you guys already resolve this issue? If so, how? Please I really need your help

[yringler]

You can use my fork at https://github.com/yringler/videojs-preroll/ The changes are based on this stack overflow. There is still a warning, because plugin() has to be replaced with registerPlugion(), but everything works; I'm using it in production now.

EDIT: I updated to registerPlugin() on my fork. Note that I didn't publish to NPM, and I didn't yet fully test, as documented in the README there. It looks like this project isn't being maintained anymore; if someone wants to take over, maybe leave a URL in a comment. Until then, feel free to drop me a PR at the above repo URL. In particular, my packages.config could probably use some work.

[yringler]

Looks like I didn't update it all the way. The lib reference (video is ads) in the example should be coming from node_modules/ npm if I remember correctly.

On Mon, Oct 26, 2020, 1:08 AM Mitch [email protected] wrote:

Hi @yringler https://github.com/yringler, I tried your fork repo but the example file still doesn't work for me. There's no /lib in your project. Any advice?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dirkjanm/videojs-preroll/issues/31#issuecomment-716306200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7B3KNDTTSRZG7T25342OLSMT74ZANCNFSM4E7GUIJA .

[liquidvisual]

@yringler Okay cheers! Sorry I got it working and deleted my post moments after I posted.

[yringler]

I was wondering about that. I thought it was a bug in my app at first. Usually I wouldn't be up at 2am anyway. One of those nights... Anyway, glad it's working for you.

[liquidvisual]

Haha no worries, I know what that's like. I'll likely be up too, trying to get this library integrated with our system. I really hope it works with RTMP streams or it's back to the drawing board.

[liquidvisual]

@yringler Sorry to bother, but have you ever used this library with Google IMA ads? Is it possible?

[yringler]

No, we only used it with internal ads, directing viewers to other content / partners etc. Is it possible? IDK. If google provides an API for IMA where you can get some sort of source URL for the ad, you should be able to work it in.

[yringler]

https://github.com/googleads/videojs-ima looks interesting

[liquidvisual]

@yringler Thanks for getting back! I just had a look and that library is just what I'm after. :D