vcstool icon indicating copy to clipboard operation
vcstool copied to clipboard

Published 20 hours ago • verified publisher icon dirk-thomas

Support authentication

Open kyrofa opened this issue 4 years ago • 8 comments

vcs_base.load_url() currently doesn't support authentication. Add support for both basic and token-based authentication by parsing netrc-formatted files. Use appdirs to support vcstool-specific authentication files for both the user and the system (user takes precedence).

kyrofa avatar Apr 22 '20 23:04 kyrofa

Huh. I'm not sure what I'm doing wrong on the mock bits for earlier pythons.

kyrofa avatar Apr 23 '20 00:04 kyrofa

Ah ha, it's an upstream python bug. All fixed now.

kyrofa avatar Apr 23 '20 21:04 kyrofa

Note that this borrows heavily from vcstools.

As discussed offline it needs to be double checked that this contribution complies with the license.

dirk-thomas avatar May 05 '20 23:05 dirk-thomas

Alright, this has been completely redesigned and rewritten from scratch. It does introduce the appdirs dependency, as discussed.

kyrofa avatar May 18 '20 20:05 kyrofa

Please add some documentation about the new auth files to the README.

Done in fc361a2287a953e9a274d1b2d37fa6fc3360ad8e, does that seem to be a sensible place to put it?

kyrofa avatar May 26 '20 20:05 kyrofa

Gentle ping here.

kyrofa avatar Sep 03 '20 19:09 kyrofa

Hey @dirk-thomas, how are you feeling about this?

kyrofa avatar Oct 22 '20 18:10 kyrofa

@kyrofa / @dirk-thomas is there a reason why this MR was not accepted?

0xjairo avatar Jan 11 '22 16:01 0xjairo