ControllerParser has inappropriate code

[devefx]

inappropriate code

if ("dwr:config-param".equals(child.getNodeName()))
{
    params.put(child.getAttribute("name"), child.getAttribute("value"));
}

correct

if ("config-param".equals(element.getLocalName()))
{
    params.put(child.getAttribute("name"), child.getAttribute("value"));
}

[mikewse]

Thanks for the report! @dmarginian : can you take a look at this?

[dmarginian]

The use of the dwr namepspace is documented on our site: http://directwebremoting.org/dwr/documentation/server/integration/spring.html

If we changed this per your recommendation I believe we would break people that read and followed our documentation.

[dmarginian]

@devefx I missed the change of getNodeName to getLocalName in the code you submitted. The proposed change could work, however, there are several other places in the code where we are using getNodeName (CreatorParserHelper) and relying on the dwr namespace. So the change is more invasive than just ControllerParser. Also, I would need to investigate using getLocalName as I know in some cases it may return null. I would suggest using the dwr namespace per our documentation for now.

[mikewse]

@devefx Everybody's busy so it would help a lot if you could describe the use case you want to solve. Some example code that a test case could be based off would also be great!