seph

Windows Controlled Folder Access (and autoupdate)

1

We occasionally get reports of launcher encountering a permissions denied error. It sometimes looks like: ``` ts=2020-01-10T15:25:21.7871962Z caller=svc_windows.go:106 severity=info msg="runLauncher exited" err="open launcher db: open C:\\Program Files\\Kolide\\Launcher-kolide-k2\\data\\launcher.db: Access is denied."...

Adjust MSI Service Settings

1

If there are service install problems, say because a prior install left the service in a weird state, `Vital=yes` means the MSI install will fail. Adjust to `Vital=no`, and `Wait=yes`...

Rework generate TUF

1

This reworks the generate-TUF routine to solve several annoyances. The underlying change, is a shift away from some hardcode notary configs, to generating them at build time. The underlying `bootstrapFromNotary`...

This fixes the support for snapshot queries in the initial runner. The first commit splits this off into it's own file, so the simpler way to see the diff is...

Windows service logs errors about "A service process other than the one launched"

1

I've seen windows service controller log: ``` A service process other than the one launched ``` Not yet sure what this means

panic during launcher autoupdate

1

Running in docker: ``` {"caller":"handler.go:84","msg":"Updated Binary ready to go","outputBinary":"/usr/local/kolide/bin/launcher-updates/1575340452/launcher","severity":"info","target":"linux/launcher-beta.tar.gz","ts":"2019-12-03T02:34:15.0471269Z"} panic: close of closed channel goroutine 31 [running]: github.com/kolide/launcher/pkg/osquery/runtime.(*Runner).Shutdown(0xc000258ff0, 0x0, 0x0) /Users/seph/go/src/github.com/kolide/launcher/pkg/osquery/runtime/runtime.go:300 +0x3b main.updateFinalizer.func1(0xc00064a060, 0xc0003322a0) /Users/seph/go/src/github.com/kolide/launcher/cmd/launcher/updater-finalizer.go:23 +0x4d github.com/kolide/launcher/pkg/autoupdate.(*Updater).handler.func1(0xc000514aa0, 0x4e, 0x0, 0x0)...

Add mutexes to osquery-go

1

As discussed in #98, osquery's communication is single threaded. This PR adds several mechanisms to help manage that. 1. Most critically, it adds mutexes to the underlying client calls to...

Should we add mutexs to osquery-go?

3

As I understand it, osquery's thrift interface is single threaded. But, this isn't mirrored in this SDK. We leave it to the caller to insure that `Query` is not called...

Constraints that are not `==` don't appear to be passed along

1

As pointed out on slack, it's not clear how to get a constraint that isn't `==` I added a spew to [`table.Call`](https://github.com/kolide/osquery-go/blob/5aaecb264273aeafc8b120728006204ee9ee2552/plugin/table/table.go#L54) and I don't see the constraints coming in....

Support for column options

4

WIP Support column options. See https://github.com/osquery/osquery/pull/6006