seph

@RebeccaMahany Did you sneak this in via a different PR?

I think we can close this then.

Fixed by https://github.com/kolide/launcher/pull/2376

> https://github.com/JodhwaniMadhur/osquery/blob/f3139976e39f1da9d743fae43b3fa2af7d4186c9/docs/wiki/installation/install-windows.md please check this and let me know if this is correct or not so then I can raise a PR If you want us to review a diff,...

I wonder if there's a way to make this part of CI.

> I wonder if we should also trim spaces; this is done by other tables like `system_info` when they query `cpuid`. Normally I would keep both embedded nulls and the...

I wonder if one of those characters isn't some unicode thing, or what's missing. Does converting it to base64 help? What do these return? - `select to_base64(cpu_brand) from system_info;` -...

Something in there is non-ascii -- `conditional_to_base64` wouldn't encode it otherwise. ``` osquery> select from_base64('SW50ZWwoUikgQ29yZShUTSkgaTctODU2NVUgQ1BVIEAgMS44MEdIegAAAAAAAAAA') == from_base64('SW50ZWwoUikgQ29yZShUTSkgaTctODU2NVUgQ1BVIEAgMS44MEdIegAAAAAAAAAA'); +--------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | from_base64('SW50ZWwoUikgQ29yZShUTSkgaTctODU2NVUgQ1BVIEAgMS44MEdIegAAAAAAAAAA') == from_base64('SW50ZWwoUikgQ29yZShUTSkgaTctODU2NVUgQ1BVIEAgMS44MEdIegAAAAAAAAAA') | +--------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | 1 | +--------------------------------------------------------------------------------------------------------------------------------------------------------------------+ osquery> select...

What's `select feature, conditional_to_base64(value) from cpuid` return for your machines?

`conditional_to_base64` is looking ascii printable characters. Specifically, in the range 0x1F - 0x7F (exclusive). I agree, the docs could be more clear.