Heritage icon indicating copy to clipboard operation
Heritage copied to clipboard

Published 20 hours ago • verified publisher icon dipth

Heirs not respecting predecessor validation?

Open marshmallowcreme opened this issue 11 years ago • 4 comments

I'm able to create child objects without satisfying the validation on the parent object.

When I try to create the parent object directly without the required field, I get the validation error like I'm supposed to. However, no complaints when I create the child object without the required parent field set.

marshmallowcreme avatar Jul 22 '13 04:07 marshmallowcreme

I solved this here:

https://github.com/marshmallowcreme/Heritage/commit/6160eda1575deea91d7328c610acf6ecd8641aae

marshmallowcreme avatar Jul 22 '13 07:07 marshmallowcreme

Could you create a pull request for this?

dipth avatar Jul 22 '13 08:07 dipth

I don't know how. I actually forked from this fork:

https://github.com/snitko/Heritage

So, I'm not sure how to submit a pull request without including all the other changes.

marshmallowcreme avatar Jul 22 '13 19:07 marshmallowcreme

In that case you might have to make a fork of this repo, then cherry pick your changes into that fork

dipth avatar Jul 23 '13 08:07 dipth