dipdup icon indicating copy to clipboard operation
dipdup copied to clipboard

Add commit hash to images built from branches and master

Open droserasprout opened this issue 2 years ago • 6 comments

For Sentry

droserasprout avatar Jul 20 '22 11:07 droserasprout

Related: #565

droserasprout avatar Dec 18 '22 21:12 droserasprout

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hey! I'm Juan Diego Carballo. 👋

I'm a Software Engineer from Heredia, Costa Rica, and a member of the Dojo Coding community. I have experience in programming languages such as Python, Rust, C#, Java, and JavaScript. I've worked with frameworks and tools like React, SpringBoot, .NET Framework, Docker, and CI/CD pipelines.

I have contributed to open-source Web3 projects such as:

  • Starknet Quest
  • Dojo
  • Op-Scan At MAFISA, I led the development and deployment of an HR web application, enhancing real-time data interaction and user experience. My work involved implementing Firebase for secure data handling and user authentication, which improved system reliability by 15% and reduced server response times by 23%. I also played a key role in continuous integration and deployment processes, ensuring high availability and operational efficiency.

Given my background in software engineering and experience with Docker and CI/CD systems, I'm confident that I can effectively address the issue of adding commit hashes to images built from branches and master in the DipDup project.

How I plan on tackling this issue

Understand the Task:

  • Carefully read the issue description to fully grasp the requirements.

  • Review the current Docker image build and tagging process in the DipDup repository.

  • :Understand how the images are currently being tagged and where the build scripts are located.

Research and Planning:

  • :Investigate best practices for incorporating commit hashes into Docker image tags.

  • Determine the appropriate method to retrieve the Git commit hash during the build process.

  • Consider any implications for existing workflows or deployment processes.

Implement the Changes:

  • Modify the CI/CD pipeline (e.g., GitHub Actions, GitLab CI) to include the commit hash in the Docker image tags for builds from branches and master.

  • Update the Dockerfile or build scripts as necessary to support the new tagging scheme.

  • Ensure that the commit hash is correctly appended to the image tags in a consistent format.

Testing:

  • Build Docker images locally to verify that the commit hash is included in the tags as expected.

  • Push test images to a private or staging registry to confirm that the new tags work with the existing deployment process.

  • Ensure that the images are correctly identified and can be pulled using the new tags.

Documentation:

  • Update any relevant documentation or README files to explain the new image tagging strategy.

  • Provide guidelines on how to interpret and use the new image tags for troubleshooting or rollbacks.

Consultation:

  • If I encounter any uncertainties or potential issues, I'll reach out to the maintainers or ask questions in the project's communication channels to ensure alignment with project standards.

Submission:

  • Once the changes are implemented and thoroughly tested, I'll open a pull request detailing the modifications.

  • : I'll provide a clear explanation of the changes and await your feedback for any necessary adjustments.

Nice to see you again and love the growth of the project @droserasprout!

juandiegocv27 avatar Sep 26 '24 08:09 juandiegocv27

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

hello i am a frontend dev and blockchain developer please can i work on this issue :) and would love to be a contributor

How I plan on tackling this issue

let me work on this issue boss

martinvibes avatar Sep 26 '24 21:09 martinvibes

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a python dev. A new-comer here, willing and ready to contribute to solve this issue.

tosoham avatar Sep 27 '24 05:09 tosoham

Hi @droserasprout, after looking into this issue, I’ve realized that I lack the experience needed in this area to tackle it effectively. I believe it’s best to pass it on to someone with more expertise. Apologies for any inconvenience, and thank you for understanding.🙏🏻

juandiegocv27 avatar Oct 02 '24 18:10 juandiegocv27

@tosoham you can take it if you want

juandiegocv27 avatar Oct 02 '24 18:10 juandiegocv27