react-virtualized-tree icon indicating copy to clipboard operation
react-virtualized-tree copied to clipboard

Iterative version of getFlattenedTree for improved performance on large datasets

Open 123joshuawu opened this issue 3 years ago • 3 comments

Addresses #84

Thank you for the great library, it has worked really well and achieved amazing results with our project.

Recently, we had a performance issue with a particularly large dataset. The tree contained roughly 140k nodes with the structure being 14 nodes containing around 10k direct children each.

This would take around 1-2 minutes to render.

Quick profiling showed that getFlattenedTree was taking around 1 minute to complete. Screen Shot 2021-04-16 at 1 08 31 PM

After changing the getFlattenedTree to an iterative implementation, the render time decreased drastically with profiling showing all getFlattenedTree calls completing within 100ms.
Screen Shot 2021-04-16 at 1 09 40 PM

Would appreciate any comments or thoughts

123joshuawu avatar Apr 16 '21 20:04 123joshuawu

Any updates for this PR?

ViktorReib avatar May 31 '21 07:05 ViktorReib

I think maintainers aren't following PRs, last update to the repo was last September =(. Might have to fork or monkey-patch if you want it.

A little investigation on the last merged PR reveals that the owner became a father, so they probably reprioritized correctly!

Cireo avatar Jun 09 '21 03:06 Cireo

A long shot but any possibility of this being merged?

ojhawkins avatar Nov 17 '22 19:11 ojhawkins