react-virtualized-tree icon indicating copy to clipboard operation
react-virtualized-tree copied to clipboard

Published 20 hours ago • verified publisher icon diogofcunha

fix: ensuring consistent interface for scrollToId

Open mateodelnorte opened this issue 4 years ago • 3 comments

fixes #134 and fixes scrollToId to correctly allow both string and number, as NodeId allows: https://github.com/diogofcunha/react-virtualized-tree/blob/master/index.d.ts#L9

Would be great to get this merged in, so that everyone using the npm package could benefit from the updated TS typings.

Thanks!

mateodelnorte avatar Jul 06 '20 19:07 mateodelnorte

Coverage Status

Coverage remained the same at 94.498% when pulling 8bf901b5412077aca7cd098936a6d899330763a3 on mateodelnorte:fix/consistent-signature-for-scrollToId into dfaaf7402d56a3eaf1034fbebfc86770d41f3700 on diogofcunha:master.

coveralls avatar Jul 06 '20 19:07 coveralls

@diogofcunha Can this PR be merged? There should be zero side effects to the fix.

mateodelnorte avatar Aug 28 '20 14:08 mateodelnorte

#153 also addresses this

Strandinator avatar Sep 01 '23 11:09 Strandinator