react-virtualized-tree icon indicating copy to clipboard operation
react-virtualized-tree copied to clipboard

Published 20 hours ago • verified publisher icon diogofcunha

Could we expose scrollToIndex ?

Open FilipeCosta06 opened this issue 4 years ago • 0 comments

Hi,

If I'm not mistaken, the scrollToIndex feature isn't exposed, only the scrollToId (I went a little more in details when I tried hijacking this closed Issue #46).

As I mentioned back there, I'm fearful the looping from scrollToId could cause serious performance drops and, considering Nodes already "know" their own index, and I have a reference to them, I think it couldn't hurt to expose scrollToIndex too. Also, the PropType seems to be wrong (again, I already detailed that in my comment).

I had tried simply exposing it myself by using the source code but I'm relatively knew to all this (especially React) and it was messed up bad (I think I wasn't resetting the value so scrolling etc... would become impossible AND I had another unrelated issue that I was fixing already ahah).

FilipeCosta06 avatar Jun 16 '20 09:06 FilipeCosta06