cryptography icon indicating copy to clipboard operation
cryptography copied to clipboard

Is this repo/package dead?

Open savejeff opened this issue 1 year ago • 7 comments

Currently, it seems it does not work/compile on Android needing pretty simple fixes to the build.gradle. No commit were made for over a year.

Before using this package in my project, I would like to be sure it gets basic fixes

savejeff avatar Oct 13 '24 09:10 savejeff

Please @terrier989 add some maintainers so we can continue working on these packages...

As mentioned in many issues like #180 and more you can find... Fix exist and it is kinda easy but .. Even pull request not been merged for long time. And those are the basic fixes.

  • #178
  • #186

Link in "README" does not work - Maintained by [gohilla.com](https://gohilla.com/). The site is gone. Link in the "group/organization" https://github.com/dint-dev - https://www.dint.dev/ works but no contact.

@terrier989 is the only public member in https://github.com/dint-dev group.

I've been waiting for fix for over a half year - even just "merging" the code would be enough.

petrleocompel avatar Oct 15 '24 06:10 petrleocompel

@petrleocompel thx for putting together the informations 👌 I have a bad feeling that the owner is not active anymore, but let's hope

savejeff avatar Oct 15 '24 07:10 savejeff

@savejeff If I will not get a response I will have to do stuff on my own... I took a look on forks... but

Screenshot 2024-10-15 at 9 05 15

The real "maintaining" is not really there. Some people just for fix one thing and does not care anymore. And then it is abandoned again.

So even I will go by route of fork .. but with automated release and try some "extra people" to invite and request like 2/3 people to validate a merge on their own.

petrleocompel avatar Oct 15 '24 07:10 petrleocompel

@savejeff I sent an email to @terrier989.

Hopefully at least that will reach him.

Still to get it of their back a little there is some stuff to do... Currently it seems releases were done manually (no CI/CD setup to publish packages to pub.dev). So to publish the package under same name it will still take some time to "setup" that from the original maintainer.

petrleocompel avatar Oct 15 '24 07:10 petrleocompel

Some updates from my side. So...

  • original authors are not responding.
  • I forked the package.
  • Created my publisher.

I am currently busy on merging all fixes from other authors (commit authors should persist). Also I am trying to make CI/CD work from github repo directly. So contributions should be easy

  • making a merge request
  • validating with CI/CD
  • making sure code and commits are okay (according to some semantic release and etc..)
  • publishing new version with "release" on github and pub.dev

I will keep you updated and post when everything is ready

petrleocompel avatar Oct 22 '24 17:10 petrleocompel

@petrleocompel appreciate you doing this!

TyBarthel avatar Oct 23 '24 20:10 TyBarthel

To all of you... We have a lift off 🚀

https://github.com/emz-hanauer/dart-cryptography

https://pub.dev/packages/cryptography_plus https://pub.dev/packages/cryptography_flutter_plus https://pub.dev/packages/jwk_plus

If anybody wants to contribute. You are welcome.

We will keep the lib alive from now on. We will "maintain" the repository. Do code-review and releases.

Breaking changes should be 0.

@TyBarthel @savejeff @terrier989

petrleocompel avatar Oct 24 '24 10:10 petrleocompel

Thank to @petrleocompel for taking over. just accepting basic fixes and improvements through merge requests should be sufficient.

Ill leave this issue open so people can find it.

For easy migration:

  
dependencies:
  # cryptography: ^2.7.0
  # cryptography_flutter: ^2.3.2 # Remove if you don't use Flutter
  cryptography_plus: ^2.7.1
  cryptography_flutter_plus: ^2.3.4 # Remove if you don't use Flutter

savejeff avatar Nov 25 '24 13:11 savejeff