dino icon indicating copy to clipboard operation
dino copied to clipboard

Adds a quote button for each message

Open MarcoPolo-PasTonMolo opened this issue 4 years ago • 10 comments

Adds a > button over each message which when clicked quotes the message. Fixes #625

There were 4 options for how the ui should've been implemented, I went with option 2.

MarcoPolo-PasTonMolo avatar Aug 22 '21 15:08 MarcoPolo-PasTonMolo

this is nice, thank you for preparing this. I rebased and tested and I can see it working.

Edit: I did remove the comment on the UI as I noticed it has to do with my configuration. So... everything is working fine!

christf avatar Nov 04 '21 09:11 christf

I suppose It's good idea. I want, that this function be added too.

serfcity avatar Feb 05 '22 18:02 serfcity

Looks useful to me.

jubalh avatar Mar 04 '22 19:03 jubalh

So.... What next?

christf avatar Mar 26 '22 11:03 christf

I have tested this PR for a long time now and it has always worked well for me. @fiaxh (or any other contributors) would you please consider merging it?

XaviDCR92 avatar May 06 '22 21:05 XaviDCR92

Generally, I think a reply button would be a good addition to Dino. However, I do not see much benefit in a button that merely puts the respective message into the chat input with a ">" in front of it. That's a work-around for actual reply support.

There's a Reply XEP currently in the making, but a dependency of that XEP needs to be reworked first before replies can be used in a backwards-compatible fashion. When the specification is finished, I'd be happy for Dino to implement it and then we can have a reply button that actually triggers a reply.

fiaxh avatar May 09 '22 08:05 fiaxh

This PR keeps consistency with https://github.com/dino/dino/pull/1111, and follows the same behaviour compared to Conversations, which might be a plus for some users. Even if this proposal is far from perfect, IMHO it is a good enough workaround until the Reply XEP is released.

XaviDCR92 avatar May 09 '22 21:05 XaviDCR92

That's a work-around for actual reply support.

In fact, this PR is implementing quotation style as described by XEP-0393.

XaviDCR92 avatar May 10 '22 19:05 XaviDCR92

@MarcoPolo-PasTonMolo You have conflicts here.

Quix0r avatar Jul 05 '22 12:07 Quix0r

@Quix0r Done sir

MarcoPolo-PasTonMolo avatar Jul 10 '22 18:07 MarcoPolo-PasTonMolo

We implemented message replies via XEP-0461 in dc52e7595cca06d0a2da7d11b3c88cb2f7ce529c.

fiaxh avatar Jan 06 '23 13:01 fiaxh