Denis Žoljom

Results 349 comments of Denis Žoljom

Just keep in mind, here we're only checking for possible code errors, I've covered all the styling that is specified in the official WordPress Coding Standards in https://github.com/WPTRT/WordPress-Coding-Standards/issues/120#issuecomment-285978768, and errors...

@jrfnl is this a different sniff from the forbidden functions one?

I've removed the input/decision needed, as we know what is and isn't allowed.

Resolution from the triage: we should add this as a sniff and add info into the requirements. Also, see if there is a chapter for this in the Theme developers...

Webpack has something similar. It appends hashes when bundling the assets, and you can use the [webpack manifest plugin ](https://github.com/danethurber/webpack-manifest-plugin) that will create `manifest.json` file that you can reference when...

Care to explain why not? I'm fine with excluding this, due to the fact I'm working with webpack, but many people are not. The idea is that if you updated...

We didn't reach a conclusion about adding this or not at the triage. I'm for including this with a warning notice, Joy is not.

As discussed on slack, I'm for option 2

This has been done, so ti can be closed, no?

@grappler Any news on the upstream issue for this?