ding-young comments

Results 29 comments of


                                            ding-young

investigate pre-prod warning: `imitate_layer_access` warns about `dropping ValuesReconstructState while some IOs have not been completed`

Hi, may I give it a try on this issue?

investigate pre-prod warning: `imitate_layer_access` warns about `dropping ValuesReconstructState while some IOs have not been completed`

Are there any specific test setups or tips for reproducing this warning message locally? I’ve been keeping an eye on this issue, but it's been challenging to reproduce the exact...

Add compression option to SpillManager

This is ready for review :) @2010YOUY01

Add compression option to SpillManager

Currently CI fails, but I think that is due to change introduced in another pr.

fix panic on failure to format generics in enum

Thank you for listing all the related issues! I included only the cases that originally lead to a rustfmt crash.

fix panic on failure to format generics in enum

About refactoring `visit_enum`, I think introducing `format_enum` would make it easier to propagate errors later, as we wouldn't need to visit all the `push_str` and `push_rewrite` calls scattered throughout. I...

fix panic on failure to format generics in enum

@avrabe Hi! I've added your test case on #6630. Haven't run it on your repository, though. Would you take a look? @TheLostLambda I lost some contexts on my pr, but...

fix panic on failure to format generics in enum

Would you mind reviewing this? @camsteffen @jieyouxu

fix: prevent panic when formatting complex generics

Hi, I just came across your PR. Would it be alright if I try it out to see if https://github.com/rust-lang/rustfmt/pull/6396 fixes the unwrap error in that test case? (This seems...